feat: send push notifications for invalid coder scheme URIs
#146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 5, 2025
ethanndickson
force-pushed
the
ethan/push-notif
branch
2 times, most recently
from
f6bc9e3 to
83b1554
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds push notification support for invalid coder scheme URIs, which involves updating the app provisioning profile and integrating notification logic into the application.
- Updated project plist with the appropriate APS environment key.
- Added a new notification delegate and helper function for sending notifications.
- Integrated asynchronous error handling with push notifications in the app delegate.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Coder-Desktop/project.yml | Inserts the APS environment configuration for push notifications. |
| Coder-Desktop/Coder-Desktop/Notifications.swift | Adds a new notification delegate and helper to send notifications. |
| Coder-Desktop/Coder-Desktop/Coder_DesktopApp.swift | Configures the notification delegate and handles errors by sending a push notification. |
Comments suppressed due to low confidence (1)
Coder-Desktop/project.yml:150
- Ensure that the 'aps-environment' key is properly indented and aligned with similar keys under the entitlements section to avoid potential configuration issues.
aps-environment: development
deansheather
approved these changes
May 6, 2025
ethanndickson
force-pushed
the
ethan/push-notif
branch
2 times, most recently
from
317524f to
e39714c
Compare
ethanndickson
force-pushed
the
ethan/uri-handler
branch
from
32ea67d to
fcfad50
Compare
ethanndickson
force-pushed
the
ethan/push-notif
branch
from
e39714c to
c25ba00
Compare
ethanndickson
force-pushed
the
ethan/uri-handler
branch
from
fcfad50 to
823c11b
Compare
Merge activity
|
ethanndickson
changed the base branch from
ethan/uri-handler
to
graphite-base/146
ethanndickson
force-pushed
the
ethan/push-notif
branch
from
c25ba00 to
db9cf55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #96.
I've had to replace the app provisioning profile for this to build.